Remove edax_files.zip from distribution #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the solution I would have suggested, so LGTM |
jat255
reviewed
Sep 3, 2018
hyperspy/tests/io/test_edax.py
Outdated
| with open(ZIPF, 'wb') as f: | ||
| f.write(r.content) | ||
| TEST_FILES_OK = os.path.isfile(ZIPF) | ||
| except BaseException: |
There was a problem hiding this comment.
Would it make sense to do a hash check here for the zip file?
There was a problem hiding this comment.
Good point, I'll fix that in a minute.
|
Thanks @jat255, it should be fine now. If nobody is against it, if this passed the tests in conda-forge, I'll merge it and release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
edax_files.ziptest files are too large and take hyperpy's distribution beyond PyPI's file size limit of 60MB. See #2048.This PR removes the file from the distribution. Instead, the test files are downloaded from GitHub. The tests are skipped if the download fails.