Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with missing metadata of EDS signal #2076

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Fix bug with missing metadata of EDS signal #2076

merged 1 commit into from
Oct 20, 2018

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 20, 2018

The estimate_parameter method of the power law component on a EDS signal was raising an error if some metadata was missing.

Progress of the PR

  • ignore live time metadata if not available,
  • add tests,
  • ready for review.

Minimal example of the bug fix or the new feature

s = hs.datasets.example_signals.EDS_TEM_Spectrum()
s.remove_background() # using the power law background

@ericpre ericpre mentioned this pull request Oct 20, 2018
Merged
@francisco-dlp francisco-dlp merged commit dc21f6b into hyperspy:RELEASE_next_patch Oct 20, 2018
@francisco-dlp francisco-dlp added this to the 1.4.1 milestone Oct 23, 2018
@ericpre ericpre deleted the fix_sum_eds_metdata branch October 24, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug type: bug-fix
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericpre @francisco-dlp