Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not just any Python 3.x version is supported - update readme #2086

Closed
wants to merge 1 commit into from
Closed

Conversation

Noiredd
Copy link

@Noiredd Noiredd commented Oct 31, 2018

Description of the change

As shown in #2083, Python 3.4 does not support the syntax used in this project. Therefore, I propose to update the readme file to mention that explicitly. Fixing the code to make it work in 3.4 is way too much pointless work, but a simple readme change might save some users (like myself) from the trouble of trying to make it work.
Due to the trivial nature of this change, I took the liberty of skipping some sections of the PR template.

Minimal example of the bug

Execute the following shell command:
python3.4 -c "import hyperspy.api"

@thomasaarholt
Copy link
Contributor

I can supply a fix in the future if someone has a need for hyperspy in Python 3.4.

@Noiredd
Copy link
Author

Noiredd commented Oct 31, 2018

@thomasaarholt Is it worth the effort? Not sure how many people use old versions - I will be updating to 3.5 or maybe some later version myself and give it a try then.

@thomasaarholt
Copy link
Contributor

In that case I'll wait until someone requests support for it. It won't take long to do, but it'll make the code a bit longer.

@ericpre
Copy link
Member

ericpre commented Oct 31, 2018

As mentioned in #2083, the main problem is not to fix it but to maintain it. Actually, after a quick look at this hyperspy 1.3 should work with python 3.4. @Noiredd, could you please confirm that 1.3 is working fine?

Copy link
Member

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a badge for the supported python version. Not sure how it works but one way may be get it through pypi and the classifiers of the setup.py file, which may need to be updated.

@@ -41,7 +41,7 @@ HyperSpy is released under the GPL v3 license.

.. warning::

**Since version 0.8.4 HyperSpy only supports Python 3. If you need to install
**Since version 0.8.4 HyperSpy only supports Python 3.5 and later. If you need to install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we know what version of hyperspy can support 3.4, mention it here.

@thomasaarholt
Copy link
Contributor

I wasn't intending to use f-strings in #1598, but @ericpre your comment in that PR re-raises this valid issue - what version of python do we intend to support in future releases?

Currently, it looks like we fully support python 3.5, but there are features like f-strings and data classes that require versions 3.6 and 3.7 respectively.

Do you and @francisco-dlp have any strong feelings about this?

@francisco-dlp
Copy link
Member

I very much like f-strings because I think that it makes the code more compact and readable. Should we drop support for 3.5 to be able to start using them? I don't know. From our point of view, certainly yes, since supporting just the latest 2 Python releases decreases the maintenance burden. However, there is a chance that there are users out there who cannot upgrade the Python version for whatever reason. What about opening an issue about it to see what users think about it?

@thomasaarholt
Copy link
Contributor

We could consider emailing out to the users to see if any are stuck with certain versions of python. There will be many users who aren't on Github.

@jat255
Copy link
Member

jat255 commented May 16, 2019 via email

@ericpre ericpre mentioned this pull request Jun 18, 2019
3 tasks
@ericpre
Copy link
Member

ericpre commented Jun 18, 2019

Fixed in #2212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants