Disable a couple of CI builds #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it to generate python35 wheels for new releases.
|
Isn't it possible to run the disabled builds only on release instead of having to comments and uncomment the code manually? |
|
I did look at it and could not a way to do but a 2nd iteration on this may be working! ;) For reference: |
|
Could you create a tag in your repo (if we do it in this one it'll create a DOI in zenodo) to test if it's really working? |
6 tasks
|
Yes, it works: |
|
Isn't it possible to do the same in travis? |
ericpre
force-pushed
the
disable_python35_test_appveyor
branch
from
e5309bd
to
8451306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the appveyor build takes more 2h to complete, because we are testing 6 different builds and there are run sequentially. The situation is significantly with travis, which is running 5 builds at the same but I would also suggest to disable the python 3.5 and python 3.6 mac osx build to save CI time.
The idea is to continuously test python 3.5 and python 3.6 support with linux and to other disable build for a release when the build will be enabled to generate the wheels. This should be a good compromise between testing across different platform and python version and saving CI time.
On a side node, conda-forge is not packaging for python 3.5 anymore (only python 3.6 and python 3.7).
Progress of the PR