Defend against more .ser files than number of metadata elements present #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttempting to read it
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2531 +/- ##
===================================================
Coverage 75.53% 75.53%
===================================================
Files 202 202
Lines 29528 29531 +3
Branches 6434 6435 +1
===================================================
+ Hits 22304 22307 +3
Misses 5403 5403
Partials 1821 1821
Continue to review full report at Codecov.
|
tjof2
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2530
As in the issue, sometimes more
.serfiles are produced than there are<ObjectInfo>elements defined in the.emi(not totally sure why). This was causing anIndexError. The proposed change checks if we have enoughobjectsbefore attempting to read from them. If not, we just do not return any metadata (since there's none to be read anyway).Also included tests to cover the new lines.