Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when loading file. #2597

Merged
merged 2 commits into from Feb 2, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 2, 2020

Progress of the PR

  • improve error message when the file can't be found.
  • update tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #2597 (c159bee) into RELEASE_next_patch (48e7c1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #2597   +/-   ##
===================================================
  Coverage               76.30%   76.30%           
===================================================
  Files                     202      202           
  Lines                   29602    29603    +1     
  Branches                 6461     6461           
===================================================
+ Hits                    22589    22590    +1     
  Misses                   5236     5236           
  Partials                 1777     1777           
Impacted Files Coverage Δ
hyperspy/io.py 82.92% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48e7c1c...479414c. Read the comment docs.

Copy link
Contributor

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpre ericpre merged commit 8b56d91 into hyperspy:RELEASE_next_patch Feb 2, 2021
@ericpre ericpre added this to the v1.6.2 milestone Feb 2, 2021
@ericpre ericpre deleted the improve_error_message branch February 2, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants