Fix for numpy 1.20 and set numpy>=1.16 #2616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st sympy doesn't support earlier version.
… that numpy<1.16 are not supported anymore and we can rely on the __array_function__ protocol.
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2616 +/- ##
======================================================
- Coverage 76.33% 76.30% -0.03%
======================================================
Files 202 202
Lines 29640 29601 -39
Branches 6469 6461 -8
======================================================
- Hits 22625 22588 -37
+ Misses 5237 5236 -1
+ Partials 1778 1777 -1
Continue to review full report at Codecov.
|
…_1.16 # Conflicts: # CHANGES.rst
|
Great stuff, LGTM |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with NEP 29 Sympy have dropped support for the numpy<1.16 in their latest release (sympy 1.7.1) and the oldest supported version CI build is failing accordingly. More libraries are going to drop support for numpy <1.16 soon and we can do the same and tidy up some code required to support numpy <1.16.
Progress of the PR
np.genfromtxtchanged behaviour https://numpy.org/devdocs/release/1.20.0-notes.html#numpy-genfromtxt-now-correctly-unpacks-structured-arrays)CHANGES.rst(if appropriate),