Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update instructions #2621

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jan 15, 2021

Closes #2618.

Progress of the PR

  • Add update instruction in the user guide,
  • add entry to CHANGES.rst,
  • ready for review.

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #2621 (750e73d) into RELEASE_next_patch (8b56d91) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #2621      +/-   ##
======================================================
+ Coverage               76.30%   76.33%   +0.02%     
======================================================
  Files                     202      202              
  Lines                   29603    29640      +37     
  Branches                 6461     6469       +8     
======================================================
+ Hits                    22590    22625      +35     
- Misses                   5236     5237       +1     
- Partials                 1777     1778       +1     
Impacted Files Coverage Δ
hyperspy/io.py 82.85% <0.00%> (-0.07%) ⬇️
hyperspy/io_plugins/digital_micrograph.py 66.85% <0.00%> (-0.07%) ⬇️
hyperspy/io_plugins/image.py 83.33% <0.00%> (ø)
hyperspy/signal.py 75.88% <0.00%> (+0.04%) ⬆️
hyperspy/io_plugins/protochips.py 95.41% <0.00%> (+0.07%) ⬆️
hyperspy/_components/gaussian.py 97.36% <0.00%> (+0.26%) ⬆️
hyperspy/_components/lorentzian.py 97.40% <0.00%> (+0.34%) ⬆️
hyperspy/_components/skew_normal.py 89.71% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b56d91...0b31813. Read the comment docs.

@ericpre
Copy link
Member Author

ericpre commented Jan 19, 2021

@NathalieBrun, based on the suggestions your made on gitter, I have updated the installation section of the user. Could you please check the follow page and comment if necessary?

https://hyperspy--2621.org.readthedocs.build/en/2621/user_guide/install.html

@NathalieBrun
Copy link

NathalieBrun commented Jan 20, 2021 via email

@ericpre
Copy link
Member Author

ericpre commented Jan 20, 2021

  • if you have an HyperSpy bundle installation can you update it using "conda update ... "? Some people told me to simply uninstall it then reinstall the new version, is it OK to do so?

Yes, this should work fine if your hyperspy bundle is not the portable one or <=2019.07.28 - see https://github.com/hyperspy/hyperspy-bundle/releases for details.

Uninstalling and reinstalling will definitively work! In the past, updating was not as easy and trouble free as of today, and I guess this is why people will choose this route!

  • in my case I had to specify the current version to update, is it a bug in my previous installation (made with Anaconda Navigator, cf 3rd question)? You could indicate in the User Guide that specify the version can solve an issue, even if you want to update with the current version.

This isn't an expected behaviour but there may be various reasons for this - most likely you had other dependencies in your environment preventing hyperspy to update, but I would imagine that this is a corner case.

  • is it not recommended to do the installation with Anaconda Navigator (which is very convenient to manage environments and versions of the different packages) ?

There are "integration issues" with Anaconda navigator: it works well only with the anaconda distribution and it doesn't always work well with conda-forge which is the community and main repository for scientific packages and the one we rely on.
Instead, I think, that we should recommend alternative to the Anaconda navigator, as mentioned in #2618 (comment).

@NathalieBrun
Copy link

NathalieBrun commented Jan 20, 2021 via email

Copy link
Contributor

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpre ericpre added this to the v1.6.2 milestone Feb 2, 2021
@ericpre ericpre merged commit 511489b into hyperspy:RELEASE_next_patch Feb 2, 2021
@ericpre ericpre mentioned this pull request Feb 2, 2021
@ericpre ericpre deleted the add_update_instructions branch February 2, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants