Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow running the test suite without the pytest-mpl plugin #2624

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jan 20, 2021

The pytest-mpl plugin is used to compare the plot output with reference images and if pytest-mpl is not installed, the test suite fails. Sometimes, it is convenient to run the test without pytest-mpl installed and this PR fixes it.

Progress of the PR

  • Fix test suite failure when pytest-mpl is not installed.
  • ready for review.

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #2624 (1b0c27a) into RELEASE_next_patch (922cbc9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #2624      +/-   ##
======================================================
- Coverage               76.58%   76.58%   -0.01%     
======================================================
  Files                     202      201       -1     
  Lines                   29698    29673      -25     
  Branches                 6497     6496       -1     
======================================================
- Hits                    22745    22724      -21     
+ Misses                   5187     5183       -4     
  Partials                 1766     1766              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922cbc9...1b0c27a. Read the comment docs.

Copy link
Contributor

@jlaehne jlaehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericpre ericpre added this to the v1.6.2 milestone Feb 27, 2021
@ericpre ericpre merged commit 4e56181 into hyperspy:RELEASE_next_patch Mar 7, 2021
@ericpre ericpre deleted the run_testsuite_without_pytest_mpl branch March 7, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants