New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO documentation #2627
IO documentation #2627
Conversation
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2627 +/- ##
======================================================
+ Coverage 76.30% 76.33% +0.02%
======================================================
Files 202 202
Lines 29641 29640 -1
Branches 6473 6469 -4
======================================================
+ Hits 22619 22625 +6
+ Misses 5238 5237 -1
+ Partials 1784 1778 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have one suggestion for improvement.
hyperspy/io_plugins/image.py
Outdated
file_format : str | ||
The fileformat defined by its extension that is any one supported by | ||
imageio (PIL/pillow), for a list see | ||
https://imageio.readthedocs.io/en/stable/formats.html. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are at it, is it worth to add passing kwds to imageio.imwrite
and update the docstring/user guide accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just stumbled across the broken links, but you are right it totally makes sense. I will pass on **kwds
both for the reader and writer.
Any idea, why the file_format
parameter is even there if it is not passed on? Maybe some legacy issue? Normally, the format will be determined automatically, but if wanted the format
argument can be passed as keyword argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is legacy and it is fine to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already adapted that in the updated version.
Description of the change
Some corrections to the IO documentation
**kwds
in image reader/writer and extend docstring.Progress of the PR