Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for lazy loading DPC and FFT #2651

Merged
merged 3 commits into from Mar 2, 2021

Conversation

din14970
Copy link
Contributor

@din14970 din14970 commented Mar 2, 2021

Description of the change

in #2564 and #2567 I added support for loading DPC and FFT signals from the FEI .emd format but didn't know how to support lazy reading. It's a tiny gap but after learning a bit about Dask this should now be resolved with this PR.

Progress of the PR

  • Change implemented (can be split into several points),
  • update docstring (if appropriate),
  • update user guide (if appropriate),
  • add entry to CHANGES.rst (if appropriate),
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #2651 (42af7bd) into RELEASE_next_patch (33dc8de) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #2651   +/-   ##
===================================================
  Coverage               76.41%   76.42%           
===================================================
  Files                     202      202           
  Lines                   29678    29680    +2     
  Branches                 6490     6490           
===================================================
+ Hits                    22679    22683    +4     
+ Misses                   5228     5227    -1     
+ Partials                 1771     1770    -1     
Impacted Files Coverage Δ
hyperspy/io_plugins/emd.py 66.63% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dc8de...42af7bd. Read the comment docs.

@din14970
Copy link
Contributor Author

din14970 commented Mar 2, 2021

Not sure why it is failing on py3.6

@ericpre
Copy link
Member

ericpre commented Mar 2, 2021

https://docs.dask.org/en/latest/changelog.html#id40

It most likely need dask > 2.3.0

@ericpre ericpre merged commit b4d1f79 into hyperspy:RELEASE_next_patch Mar 2, 2021
@ericpre ericpre added this to the v1.6.2 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants