Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix finding dataset in group in EMD NCEM file #2673

Merged
merged 5 commits into from Mar 15, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Mar 12, 2021

Fixes #2614.

Progress of the PR

  • Fix bug with finding dataset path for (non-complicant?) file containing several dataset in a group,
  • add entry to CHANGES.rst (if appropriate),
  • ready for review.

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #2673 (8015984) into RELEASE_next_patch (240bf42) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #2673   +/-   ##
===================================================
  Coverage               76.62%   76.62%           
===================================================
  Files                     201      201           
  Lines                   29681    29683    +2     
  Branches                 6500     6501    +1     
===================================================
+ Hits                    22743    22745    +2     
  Misses                   5177     5177           
  Partials                 1761     1761           
Impacted Files Coverage Δ
hyperspy/io_plugins/emd.py 66.70% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 240bf42...8015984. Read the comment docs.

@jlaehne jlaehne linked an issue Mar 15, 2021 that may be closed by this pull request
@jlaehne
Copy link
Contributor

jlaehne commented Mar 15, 2021

LGTM

@jlaehne jlaehne merged commit bddacac into hyperspy:RELEASE_next_patch Mar 15, 2021
@ericpre ericpre deleted the fix_emd branch March 15, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMD (NCEM) io_plugin no longer imports mettadata
2 participants