Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation_mask decomposition #2679

Merged
merged 4 commits into from Mar 18, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Mar 16, 2021

Fixes #2677. When passing a numpy array for the navigation_mask argument of decomposition, the array was missing a transpose operation. Passing hyperspy signal is working fine.

Progress of the PR

  • Fix plotting boolean array (didn't play well with auto contrast).
  • add entry to CHANGES.rst (if appropriate),
  • add tests,
  • ready for review.

Minimal example of the bug fix.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #2679 (9d3c546) into RELEASE_next_patch (d4d3dcb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #2679      +/-   ##
======================================================
+ Coverage               76.66%   76.67%   +0.01%     
======================================================
  Files                     201      201              
  Lines                   29666    29670       +4     
  Branches                 6495     6496       +1     
======================================================
+ Hits                    22743    22750       +7     
+ Misses                   5168     5167       -1     
+ Partials                 1755     1753       -2     
Impacted Files Coverage Δ
hyperspy/drawing/image.py 72.63% <100.00%> (+0.20%) ⬆️
hyperspy/learn/mva.py 82.92% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d3dcb...9d3c546. Read the comment docs.

@jlaehne
Copy link
Contributor

jlaehne commented Mar 18, 2021

LGTM

@jlaehne jlaehne merged commit eab3da3 into hyperspy:RELEASE_next_patch Mar 18, 2021
@ericpre ericpre deleted the fix_mask_decomposition branch March 18, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants