New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bruker XRF #2694
Bruker XRF #2694
Conversation
… because the anaconda dask-core is broken.
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_patch #2694 +/- ##
===================================================
Coverage 76.93% 76.94%
===================================================
Files 201 201
Lines 29706 29711 +5
Branches 6513 6515 +2
===================================================
+ Hits 22854 22860 +6
Misses 5105 5105
+ Partials 1747 1746 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what goes with azure and matplotlib, but bruker side looks good to me;
Albeit, I wish there some note would go somewhere in the hyperspy metadata that this is not electron based EDS but X-ray excitation based EDS. (As Far I can remember there was some PR/issue to make new signal for XRF)
Thanks @sem-geologist for the review, indeed the metadata needs some changes! |
…ion in conda_environment.yml: issues with anaconda defaults packages.
Add support for XRF bruker file as described by @ffsedd and speed up setting conda environment by removing unnecessary dependencies.
Progress of the PR
CHANGES.rst
(if appropriate),