New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for binned non_uniform_axes #2728
Fixes for binned non_uniform_axes #2728
Conversation
Codecov Report
@@ Coverage Diff @@
## non_uniform_axes #2728 +/- ##
====================================================
+ Coverage 77.50% 77.81% +0.31%
====================================================
Files 203 203
Lines 31066 31103 +37
Branches 6782 6791 +9
====================================================
+ Hits 24077 24204 +127
+ Misses 5159 5096 -63
+ Partials 1830 1803 -27
Continue to review full report at Codecov.
|
The failing test in For the remaining 3 Codecov warnings I am not sure which test to amend to catch these lines. |
Aside from a few small comments, LGTM! Excellent choice of axis name and units in the tests - "lovely plumage" :) |
Yes, we definitely need more Monty (in HyperSpy's) Python :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first iteration of comments, I may have some more later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There is one docstring left to update and two comments I will leave it to you, if you want to take them into account or not.
I took into account all the comments, thanks for all the feedback @ericpre and @thomasaarholt. |
Really nice @jlaehne! |
Work on key issues from #2398
Description of the change
convert_to_non_uniform_axis
(index_in_array
was lost)axes.py
and other files affected by the non-uniform axis branchProgress of the PR