Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nightly merge workflow #2732

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented May 4, 2021

Following setting the default permissions for the hyperspy organization to "read contents" as mentioned in #2727 (comment), the nightly merge workflow fails as expected.

Progress of the PR

  • Review action code and update robotology/gh-action-nightly-merge version
  • Add write contents permission.
  • Ready for review.

@ericpre ericpre changed the base branch from RELEASE_next_patch to RELEASE_next_minor May 4, 2021 19:58
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2732 (74649fe) into RELEASE_next_minor (c799250) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_minor    #2732   +/-   ##
===================================================
  Coverage               77.69%   77.69%           
===================================================
  Files                     203      203           
  Lines                   30627    30627           
  Branches                 6670     6670           
===================================================
  Hits                    23796    23796           
  Misses                   5051     5051           
  Partials                 1780     1780           
Impacted Files Coverage Δ
hyperspy/model.py 80.23% <0.00%> (ø)
hyperspy/component.py 85.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c799250...74649fe. Read the comment docs.

@jlaehne jlaehne merged commit f477384 into hyperspy:RELEASE_next_minor May 5, 2021
@ericpre ericpre deleted the fix_nightly_merge_workflow branch May 10, 2021 12:28
@ericpre ericpre added this to the v1.7 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants