New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix estimate_parameters for binned and non uniform axis #2743
Fix estimate_parameters for binned and non uniform axis #2743
Conversation
Codecov Report
@@ Coverage Diff @@
## non_uniform_axes #2743 +/- ##
====================================================
- Coverage 78.02% 77.88% -0.14%
====================================================
Files 203 203
Lines 31607 31144 -463
Branches 7020 6807 -213
====================================================
- Hits 24662 24258 -404
+ Misses 5130 5086 -44
+ Partials 1815 1800 -15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and I have left a couple of comments.
I will leave someone else to review/merge it since I influenced this PR!
Looks good on first sight, I'll have a closer look in the next days when I find some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just need a tiny bit of tidying up. @jlaehne, I leave it to you. Thanks!
17d7450
to
914bebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the help with the nua branch! I left a few questions, but as said previously this looks good otherwise.
OK, I merge this PR as the main objectives are more than covered. Further optimization that we discussed at several points can be contributed as new PRs. Thanks again! |
This was a nice ride. Thank you! |
Description of the change
Rebase of PR #2740 with the correct version of
non_uniform_axes
.Fixes #2739.
Summary: this PR fixes incorrect behaviour in
BaseDataAxis.value2index()
which was not accepting arrays as input and was computing the axis gradient even for non-binned axes.Progress of the PR