Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-uniform updates (NotImplementedErrors, tests, spelling, saving-fix) #2761

Merged
merged 10 commits into from Jun 3, 2021

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Jun 2, 2021

Description of the change

  • Replace remaining mentions of 'non-linear' instead of 'non-uniform' axis
  • Replace remaining misspellings of 'non uniform' instead of 'non-uniform' axis
  • Add missing catches for non-uniform axis few sentences and/or a bulleted list to describe and motivate the change:
  • Implement interpolate_in_between for non-uniform axis with delta being float
  • fix error in io-save-code introduced by some merge of RnM: https://github.com/hyperspy/hyperspy/pull/2399/files#r629224770

Progress of the PR

  • Changes implemented (can be split into several points),
  • add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #2761 (6d4de2a) into non_uniform_axes (516b193) will increase coverage by 0.04%.
The diff coverage is 89.47%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           non_uniform_axes    #2761      +/-   ##
====================================================
+ Coverage             77.90%   77.95%   +0.04%     
====================================================
  Files                   203      203              
  Lines                 31166    31136      -30     
  Branches               6807     6804       -3     
====================================================
- Hits                  24280    24271       -9     
+ Misses                 5085     5064      -21     
  Partials               1801     1801              
Impacted Files Coverage Δ
hyperspy/component.py 85.61% <ø> (ø)
hyperspy/datasets/artificial_data.py 98.64% <ø> (ø)
hyperspy/io_plugins/hspy.py 68.60% <ø> (ø)
hyperspy/models/model1d.py 87.96% <ø> (ø)
hyperspy/_signals/signal1d.py 77.73% <80.00%> (+0.30%) ⬆️
hyperspy/io.py 84.67% <100.00%> (+6.69%) ⬆️
hyperspy/io_plugins/emd.py 66.95% <100.00%> (ø)
hyperspy/io_plugins/jeol.py 92.28% <100.00%> (+0.02%) ⬆️
hyperspy/signal_tools.py 69.02% <100.00%> (+0.15%) ⬆️
hyperspy/io_plugins/msa.py 75.75% <0.00%> (-1.22%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 516b193...6d4de2a. Read the comment docs.

@jlaehne jlaehne changed the title non-uniform updates non-uniform updates (NotImplementedErrors, tests, spelling) Jun 2, 2021
@jlaehne jlaehne mentioned this pull request Jun 2, 2021
Copy link
Member

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I added suggestions for improvement to make it slightly more readable.

hyperspy/io.py Outdated Show resolved Hide resolved
hyperspy/io.py Outdated Show resolved Hide resolved
hyperspy/io.py Outdated Show resolved Hide resolved
hyperspy/tests/signals/test_1D_tools.py Outdated Show resolved Hide resolved
@jlaehne jlaehne changed the title non-uniform updates (NotImplementedErrors, tests, spelling) non-uniform updates (NotImplementedErrors, tests, spelling, saving-fix) Jun 3, 2021
@ericpre ericpre merged commit edd9937 into hyperspy:non_uniform_axes Jun 3, 2021
@jlaehne jlaehne deleted the nua_lastcatches branch June 3, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants