Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.6.3 #2768

Merged
merged 5 commits into from
Jun 10, 2021
Merged

Release 1.6.3 #2768

merged 5 commits into from
Jun 10, 2021

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Jun 10, 2021

Since #2726 and #2731 is a bad regression and that releasing is much easier now, I suggest that we do 1.6.3?

Is there any other issue which should be included in the next patch release?

Release test workflow in my fork: https://github.com/ericpre/hyperspy/actions/runs/924627005

Releasing guide: https://github.com/hyperspy/hyperspy/blob/RELEASE_next_minor/releasing_guide.md

Progress of the PR

  • bump version number,
  • update changelog: run towncrier build
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • ready for review.

@ericpre ericpre added this to the v1.6.3 milestone Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #2768 (abee0ec) into RELEASE_next_patch (76d4e22) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           RELEASE_next_patch    #2768   +/-   ##
===================================================
  Coverage               77.30%   77.30%           
===================================================
  Files                     202      202           
  Lines                   30038    30038           
  Branches                 6562     6562           
===================================================
  Hits                    23222    23222           
+ Misses                   5068     5067    -1     
- Partials                 1748     1749    +1     
Impacted Files Coverage Δ
hyperspy/Release.py 100.00% <100.00%> (ø)
hyperspy/model.py 80.26% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d4e22...abee0ec. Read the comment docs.

CHANGES.rst Outdated Show resolved Hide resolved
@francisco-dlp
Copy link
Member

Except for the teeny comment, this looks excellent to me.

@ericpre
Copy link
Member Author

ericpre commented Jun 10, 2021

Since the github workflow permissions are now read only, it was necessary to add write permission to the job creating the release - see #2727 (comment)

@ericpre ericpre merged commit ac7981a into RELEASE_next_patch Jun 10, 2021
@ericpre ericpre deleted the RELEASE_1.6.3 branch June 10, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants