Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr Reading and Writing (.zspy format) - Reformatted #2825
Zarr Reading and Writing (.zspy format) - Reformatted #2825
Changes from 16 commits
5d94aa7
2270bd7
0e6d705
37d5fe0
8e27d65
af590ee
023630b
28350a5
c6f8178
6021f3f
db105d5
fc2302d
f766284
7fe289a
57d96f1
665dc59
f0a2144
4132db5
b83ec5d
9fffe4c
cf8632e
fb4c048
48c88f6
efd1086
b9be6fc
ad0902b
9840bcc
31d27b0
0e98cae
88b38bc
cb45958
d863064
3132e22
2b236f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more alternative would be to define the
store
argument to pass a zarr store, for example, as defined bystore = zarr.ZipStore('data/example.zip', mode='w')
. If the store argument is specified, then the zspy can pick up the path from the store itself and it doesn't need to be defined explicitely.An even more simple alternative is to accept zarr store for the filename but I am not convinced it is good because it is a bit misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I considered both of those possibilities but decided against them for kind of the reason you described above.
For the passing of a store argument your filename doesn't really mean anything as only the store argument will be passed. If I remember correctly this complicates things a little bit.
The second one is pretty do-able and I think that I got it working at one point. I could be convinced to get that working again. The question is if that really makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going for option 2 should be good because this is a pattern used by the
zarr.group
, as it can take a path or a zarr store as first argument.