Fixes for matplotlib 3.5 and simplify maintenance of RangeWidget
#2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht axis was hidden behind the first axis with non-blitting backend; with blitting, the curve are animated and draw above the background in any case
…lib 3.5. However, we still need to use a local copy of the matplotlib selector to support older version of matplotlib and the `snap_value` feature is missing in matplotlib 3.5
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2922 +/- ##
======================================================
+ Coverage 80.08% 80.60% +0.52%
======================================================
Files 209 209
Lines 32580 32294 -286
Branches 7334 7265 -69
======================================================
- Hits 26093 26032 -61
+ Misses 4736 4513 -223
+ Partials 1751 1749 -2
Continue to review full report at Codecov.
|
ericpre
force-pushed
the
tidy_up_range_widget
branch
2 times, most recently
from
ba128cc
to
9ec136b
Compare
This was referenced Apr 7, 2022
Closed
jlaehne
approved these changes
Apr 13, 2022
ericpre
force-pushed
the
tidy_up_range_widget
branch
from
9ec136b
to
7244e87
Compare
jlaehne
approved these changes
Apr 14, 2022
|
thanks for the significant increase in coverage! |
jlaehne
added a commit
to hyperspy/hyperspy_gui_traitsui
that referenced
this pull request
Apr 16, 2022
Update background removal for hyperspy/hyperspy#2922
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress of the PR
RangeWidgetModifiableSpanSelector, now that the features we need are implemented inmatplotlib,SpanSelectorto support older version of matplotlibpatchattribute of widgets a property,upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)