New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up of #2972 and tidy up left up rosettasciio #2988
Merged
jlaehne
merged 4 commits into
hyperspy:RELEASE_next_major
from
ericpre:tidy_up_rosettasciio
Aug 24, 2022
Merged
Follow up of #2972 and tidy up left up rosettasciio #2988
jlaehne
merged 4 commits into
hyperspy:RELEASE_next_major
from
ericpre:tidy_up_rosettasciio
Aug 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_major #2988 +/- ##
======================================================
+ Coverage 78.88% 80.28% +1.40%
======================================================
Files 183 176 -7
Lines 25553 24654 -899
Branches 5854 5589 -265
======================================================
- Hits 20157 19794 -363
+ Misses 3936 3514 -422
+ Partials 1460 1346 -114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jlaehne
reviewed
Aug 23, 2022
7 tasks
ericpre
force-pushed
the
tidy_up_rosettasciio
branch
from
August 24, 2022 18:06
45d4930
to
1158e91
Compare
ericpre
commented
Aug 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be all done!
jlaehne
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #2972 to use https://github.com/hyperspy/rosettasciio.
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)