Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up of #2972 and tidy up left up rosettasciio #2988

Merged
merged 4 commits into from Aug 24, 2022

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 21, 2022

Follow up of #2972 to use https://github.com/hyperspy/rosettasciio.

Progress of the PR

  • Remove rosettasciio folder,
  • update CI workflow accordingly,
  • update dependency requirement,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • [n/a] add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • [n/a] Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • add tests,
  • ready for review.

@ericpre ericpre added this to the v2.0 HyperSpy Split milestone Aug 21, 2022
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #2988 (1158e91) into RELEASE_next_major (799c8f1) will increase coverage by 1.40%.
The diff coverage is 100.00%.

@@                  Coverage Diff                   @@
##           RELEASE_next_major    #2988      +/-   ##
======================================================
+ Coverage               78.88%   80.28%   +1.40%     
======================================================
  Files                     183      176       -7     
  Lines                   25553    24654     -899     
  Branches                 5854     5589     -265     
======================================================
- Hits                    20157    19794     -363     
+ Misses                   3936     3514     -422     
+ Partials                 1460     1346     -114     
Impacted Files Coverage Δ
hyperspy/io.py 64.59% <100.00%> (+13.97%) ⬆️
hyperspy/signal.py 76.76% <0.00%> (-0.03%) ⬇️
rosettasciio/rsciio/utils/tools.py
rosettasciio/rsciio/version.py
rosettasciio/rsciio/utils/rgb_tools.py
hyperspy/axes.py 90.72% <0.00%> (+<0.01%) ⬆️
hyperspy/_signals/eds_tem.py 83.79% <0.00%> (+0.05%) ⬆️
hyperspy/model.py 83.70% <0.00%> (+0.10%) ⬆️
hyperspy/samfire.py 65.54% <0.00%> (+0.10%) ⬆️
hyperspy/misc/utils.py 90.37% <0.00%> (+0.15%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

conda_environment.yml Outdated Show resolved Hide resolved
hyperspy/io.py Outdated Show resolved Hide resolved
hyperspy/tests/test_io.py Show resolved Hide resolved
Copy link
Member Author

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all done!

hyperspy/tests/test_io.py Show resolved Hide resolved
hyperspy/io.py Outdated Show resolved Hide resolved
@ericpre ericpre requested a review from jlaehne August 24, 2022 20:38
@jlaehne jlaehne merged commit ba0deb6 into hyperspy:RELEASE_next_major Aug 24, 2022
@ericpre ericpre deleted the tidy_up_rosettasciio branch September 4, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants