-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation - Axes, IO, Model #2998
Remove deprecation - Axes, IO, Model #2998
Conversation
7693e3d
to
1b21b11
Compare
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_major #2998 +/- ##
======================================================
+ Coverage 80.29% 80.41% +0.12%
======================================================
Files 176 176
Lines 24648 24586 -62
Branches 5591 5577 -14
======================================================
- Hits 19790 19771 -19
+ Misses 3512 3479 -33
+ Partials 1346 1336 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1ca3449
to
fcb0d54
Compare
fcb0d54
to
5162d78
Compare
I have seen in the RosettaSciIO deprecation PR that not always the changed terminology was properly documented in the user guide. So the documentation should be searched again for all deprecated names in the three deprecation PRs to make sure that there are no remnants of old terminology. |
Yes, this should be done after we remove all deprecation? |
It could be done in each of the three branches for the respective keywords and functions by searching a local copy (as I did in hyperspy/rosettasciio#30). Otherwise, we should add a checkpoint to the todo list in #2996 |
As there are many deprecations, I made several PRs, so it is not too much pain to review, but the drawback of this approach is that, it is more difficult to find some left over which is why I suggested to do it later. |
OK, I added to the todo list in #2996 |
Sorry, I missed the point that you were referring to the user guide! |
fad7992
to
91eb1fa
Compare
I added a PR with some changes to the documentation. |
adapt user guide
First round of deprecation removal.
Progress of the PR
axes.py
,io.py
,model.py
,upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)