Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog rsciio deprecation #3002

Merged

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Aug 29, 2022

Description of the change

Changelog entry for deprecations of IO plugins, see hyperspy/rosettasciio#30

(should come after the other deprecation entries in the changelog and thus maybe should be merged after them?)

Progress of the PR

  • Change implemented (can be split into several points),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • ready for review.

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #3002 (a51dbb9) into RELEASE_next_minor (075f99d) will decrease coverage by 0.52%.
The diff coverage is 73.07%.

@@                  Coverage Diff                   @@
##           RELEASE_next_minor    #3002      +/-   ##
======================================================
- Coverage               80.81%   80.28%   -0.53%     
======================================================
  Files                     209      176      -33     
  Lines                   32708    24654    -8054     
  Branches                 7325     5589    -1736     
======================================================
- Hits                    26432    19794    -6638     
+ Misses                   4514     3514    -1000     
+ Partials                 1762     1346     -416     
Impacted Files Coverage Δ
hyperspy/exceptions.py 58.33% <ø> (-0.55%) ⬇️
hyperspy/learn/mva.py 82.96% <ø> (ø)
hyperspy/logger.py 100.00% <ø> (ø)
hyperspy/misc/array_tools.py 80.14% <ø> (-2.21%) ⬇️
hyperspy/misc/eels/eelsdb.py 73.41% <ø> (ø)
hyperspy/misc/example_signals_loading.py 100.00% <ø> (ø)
hyperspy/misc/utils.py 90.37% <ø> (-0.64%) ⬇️
hyperspy/signal.py 76.76% <ø> (-0.23%) ⬇️
hyperspy/io.py 64.59% <64.91%> (-22.23%) ⬇️
hyperspy/_signals/lazy.py 91.08% <66.66%> (-0.79%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ericpre ericpre changed the base branch from RELEASE_next_minor to RELEASE_next_major August 30, 2022 06:37
@ericpre ericpre merged commit c2ce3a5 into hyperspy:RELEASE_next_major Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants