Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin third party GitHub actions #3027

Merged

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Sep 19, 2022

Follow up of #2727

I tested using SHA as pin it in other repositories (for example in https://github.com/hyperspy/hyperspy-bundle/actions/runs/3084138812) and this is working fine.

Progress of the PR

  • Update github workflow,
  • pin third party actions,
  • [n/a] update docstring (if appropriate),
  • update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 80.83% // Head: 80.83% // No change to project coverage 👍

Coverage data is based on head (82cc64b) compared to base (e470aba).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           RELEASE_next_minor    #3027   +/-   ##
===================================================
  Coverage               80.83%   80.83%           
===================================================
  Files                     209      209           
  Lines                   32718    32718           
  Branches                 7332     7332           
===================================================
  Hits                    26447    26447           
  Misses                   4505     4505           
  Partials                 1766     1766           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

doc/dev_guide/maintenance.rst Outdated Show resolved Hide resolved
doc/dev_guide/maintenance.rst Outdated Show resolved Hide resolved
doc/dev_guide/maintenance.rst Outdated Show resolved Hide resolved
doc/dev_guide/maintenance.rst Outdated Show resolved Hide resolved
@ericpre ericpre force-pushed the pin_third_party_github_actions branch from f2e4969 to 82cc64b Compare September 20, 2022 20:46
@jlaehne jlaehne merged commit c6a6543 into hyperspy:RELEASE_next_minor Sep 24, 2022
@ericpre ericpre deleted the pin_third_party_github_actions branch September 25, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants