-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dask.array.random
2023.2.1
#3103
Fix dask.array.random
2023.2.1
#3103
Conversation
…andomState and start to use np.random.default_rng in test suite instead
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_patch #3103 +/- ##
======================================================
- Coverage 81.00% 81.00% -0.01%
======================================================
Files 209 209
Lines 32753 32770 +17
Branches 7237 7242 +5
======================================================
+ Hits 26533 26545 +12
- Misses 4466 4470 +4
- Partials 1754 1755 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2a9f814
to
7cce0eb
Compare
@CSSFrancis, @jlaehne, @francisco-dlp, can one of you review this PR? |
I have a bit of free time and can do it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like all pretty straight forward changes. The only thing that I thought might be worth doing extra is adding a comment where you change a couple of the tests incase someone is testing with an older version of numpy and those tests start to fail. It might give some idea of why that is the case.
Co-authored-by: Carter Francis <csfrancis@wisc.edu>
Dask 2023.2.1 refactor the code to generate random numbers and now follows the syntax introduced in numpy 1.17 - see #3049 and https://numpy.org/doc/stable/reference/random/new-or-different.html#new-or-different for more details.
Progress of the PR
numpy.random.RandomState
and start to usenp.random.default_rng
in test suite instead,,np.random.default_rng
,numpy.random.RandomState
,upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)