New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Clean Up #3198
Merged
CSSFrancis
merged 23 commits into
hyperspy:RELEASE_next_major
from
CSSFrancis:map_clean_up
Sep 7, 2023
Merged
Map Clean Up #3198
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
6bd2a9a
Refactor: Remove parallel option in favor of setting outside of map f…
CSSFrancis afe9608
NewFeature: Added navigation chunks parameter for setting the navigat…
CSSFrancis d2dd0f5
Testing: Removed all references to parallel kwarg
CSSFrancis e35f476
Testing: Removed parallel reference in documentation
CSSFrancis 69d116e
Documentation: Added examples using Single threaded and distributed b…
CSSFrancis e52b342
Documentation: Add changelog
CSSFrancis f14b8d8
Testing: Add tests for setting chunks
CSSFrancis 272d7d2
Documentation: Added additional example for map function
CSSFrancis 904a4e0
Refactor: Remove parallel option in favor of setting outside of map f…
CSSFrancis dec3661
NewFeature: Added navigation chunks parameter for setting the navigat…
CSSFrancis 59a26f0
Testing: Removed all references to parallel kwarg
CSSFrancis 0e78479
Testing: Removed parallel reference in documentation
CSSFrancis 10759f9
Documentation: Added examples using Single threaded and distributed b…
CSSFrancis 7a728cd
Documentation: Add changelog
CSSFrancis 868157b
Testing: Add tests for setting chunks
CSSFrancis 79ffe2a
Documentation: Added additional example for map function
CSSFrancis 380cf35
Tweak documentation
ericpre c22e028
Fix `_map_all`: remove axis when necessary
ericpre 13e7f7e
Rename `max_workers` to `num_workers` to be consistent with dask
ericpre 1f584d8
Merge remote-tracking branch 'origin/map_clean_up' into map_clean_up
CSSFrancis 59494af
Documentation: Moved documentation for dask-scheduling
CSSFrancis 9a341f5
Documentation: Fixed codeblock not showing up and fixed spelling for …
CSSFrancis 1b2f0cc
Documentation: Fixed spelling error
CSSFrancis File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this example here, the example of the gallery needs to be run and I am not that it would be possible/easy on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I think maybe the distributed workflow would run but not the slurm workflow so you are right we should move it.