align_zero_loss_peak should take left and right arguments for low loss spectra #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_minor #3249 +/- ##
======================================================
+ Coverage 81.01% 81.04% +0.03%
======================================================
Files 209 209
Lines 32806 32806
Branches 7540 7540
======================================================
+ Hits 26579 26589 +10
+ Misses 4469 4456 -13
- Partials 1758 1761 +3
☔ View full report in Codecov by Sentry. |
|
Thanks @HanHsuanWu for the PR, but the EELS/EDS has been split yesterday and these changes now needs to go to https://github.com/hyperspy/exspy. As you discussed in #3248, currently to use exspy, you will need development branch of hyperspy_gui_traitsui and hyperspy_gui_ipywidgets. In case you don't want to mess around with these, in one work or two, we should have a release candidate of hyperspy and these things should be settled. |
|
So should I make the pull request in exspy instead? |
|
Yes. |
|
Closing in favour of hyperspy/exspy#7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Adding additional description for align_zero_loss_peak and added left and right arguments.
When subpixel = True, align1D (with cross-correlation) is used. The range of align1D depends on variables "left" and "right."
Currently by default, left and right are set to be -3. and 3. I think these are in whichever unit the energy axis is in.
Thus, for low loss data that are in the units of meV being about to adjust them will be helpful.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)