Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #3320

Merged
merged 12 commits into from
Feb 26, 2024
Merged

Fix warnings #3320

merged 12 commits into from
Feb 26, 2024

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Feb 25, 2024

Progress of the PR

  • Fix deprecation scipy, matplotlib and numpy deprecation warnings,
  • Bump scipy from 1.5 to 1.6 to be able to use scipy.integrate.simpson instead of deprecated scipy.integrate.simps,
  • Fix warning in test suite,
  • Set OMP_NUM_THREADS as a default to run the test suite to avoid sklearn warning with MKL and possibly failure on Azure Pipelines CI (windows),
  • Tidy up some tests which were redundant,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • update tests,
  • ready for review.

@ericpre ericpre added this to the v2.0.1 milestone Feb 25, 2024
Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.51%. Comparing base (662a80b) to head (21cdabd).

Files Patch % Lines
hyperspy/external/astropy/histogram.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           RELEASE_next_patch    #3320      +/-   ##
======================================================
+ Coverage               80.25%   80.51%   +0.25%     
======================================================
  Files                     147      147              
  Lines                   21860    21869       +9     
  Branches                 5143     5146       +3     
======================================================
+ Hits                    17543    17607      +64     
+ Misses                   3111     3044      -67     
- Partials                 1206     1218      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre
Copy link
Member Author

ericpre commented Feb 25, 2024

@jlaehne, @CSSFrancis, once this PR is merged, I would suggest to make a quick 2.0.1 release?

hyperspy/axes.py Outdated Show resolved Hide resolved
hyperspy/utils/plot.py Outdated Show resolved Hide resolved
@jlaehne
Copy link
Contributor

jlaehne commented Feb 26, 2024

One of the Package & Test workflows fails with AttributeError: module 'mpmath' has no attribute 'rational'

Seems to originate from a recent pre-release of mpmath: NVIDIA/TensorRT-LLM#1145

@jlaehne
Copy link
Contributor

jlaehne commented Feb 26, 2024

@jlaehne, @CSSFrancis, once this PR is merged, I would suggest to make a quick 2.0.1 release?

Fixed a few typos, otherwise very good idea to reduce the number of warnings.

@ericpre
Copy link
Member Author

ericpre commented Feb 26, 2024

One of the Package & Test workflows fails with AttributeError: module 'mpmath' has no attribute 'rational'

Seems to originate from a recent pre-release of mpmath: NVIDIA/TensorRT-LLM#1145

Changed to install mpmath separately (without the --pre flag) as a workaround in hyperspy/.github@b4c0b09.

@ericpre ericpre merged commit 1d225cc into hyperspy:RELEASE_next_patch Feb 26, 2024
25 checks passed
@ericpre ericpre deleted the fix_warnings branch February 29, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants