-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update residual line when model line is changed. #3352
Update residual line when model line is changed. #3352
Conversation
I think it would make sense to rebase this on |
@HanHsuanWu, in case you are familiar with rebasing, there are some basic instructions in the developer guide on how to rebase - you may find more detailed instructions elsewhere online but this is not always very clear when not familiar with git! The difference between the various branches that we use is explained in the developer guide too. |
Update residual line when model line is changed. hyperspy#3352
Thanks guys I opened a new commit in #3355. |
Closing in favour of #3355. |
Update residual line when model line is changed. hyperspy#3352
Currently, the plotted residual is not being updated whenever the model line changes.
So I added update for model._residual_line whenever mode._model_line is being updated.