Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only import gui widget when the toolkit is enabled #3366

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented May 4, 2024

Progress of the PR

  • Only import gui widget when the toolkit is enabled to avoid unnecessary import of gui library,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • [n/a] add tests,
  • ready for review.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (de16955) to head (f226818).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           RELEASE_next_minor    #3366   +/-   ##
===================================================
  Coverage               80.53%   80.53%           
===================================================
  Files                     146      146           
  Lines                   21864    21864           
  Branches                 5152     5152           
===================================================
  Hits                    17609    17609           
  Misses                   3037     3037           
  Partials                 1218     1218           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre added this to the v2.1 milestone May 4, 2024
@ericpre ericpre mentioned this pull request May 6, 2024
10 tasks
@ericpre ericpre modified the milestones: v2.1, v2.2 May 8, 2024
@ericpre ericpre force-pushed the avoid_importing_toolkit_when_not_enabled branch from f226818 to e6a9690 Compare June 6, 2024 07:38
@ericpre ericpre changed the base branch from RELEASE_next_minor to RELEASE_next_patch June 6, 2024 07:38
@ericpre ericpre modified the milestones: v2.2, v2.1.1 Jun 6, 2024
@ericpre
Copy link
Member Author

ericpre commented Jun 6, 2024

@francisco-dlp, can you please have a look at this PR? This should be fairly straightforward.

Copy link
Member

@francisco-dlp francisco-dlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works fine. Merging.

@francisco-dlp francisco-dlp merged commit 35b09c4 into hyperspy:RELEASE_next_patch Jun 6, 2024
26 checks passed
@ericpre ericpre deleted the avoid_importing_toolkit_when_not_enabled branch June 6, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants