Support numpy 2.0 #3386
Open
Support numpy 2.0 #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spy exceptions instead of numpy exceptions
…now macos-14 with arm64
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RELEASE_next_patch #3386 +/- ##
======================================================
+ Coverage 80.62% 80.64% +0.02%
======================================================
Files 146 146
Lines 21918 21921 +3
Branches 5173 5176 +3
======================================================
+ Hits 17671 17678 +7
+ Misses 3029 3026 -3
+ Partials 1218 1217 -1 ☔ View full report in Codecov by Sentry. |
jlaehne
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Looks all sensible to me, but maybe a second review would not hurt @francisco-dlp @CSSFrancis
| @@ -43,7 +48,7 @@ jobs: | |||
| PYTHON_VERSION: '3.11' | |||
| PIP_SELECTOR: '[all, tests, coverage]' | |||
| - os: macos | |||
| os_version: '14' | |||
| os_version: '13' | |||
There was a problem hiding this comment.
Why run on a lower macos version?
There was a problem hiding this comment.
To test on both architectures currently available on mac: intel and arm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that matplotlib and pint supports numpy 2.0, we can test hyperspy against the pre-release of numpy.
xref hyperspy/hyperspy-extensions-list#56
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)