Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing nverts in graticule has no effect #16

Open
dramanica opened this issue Apr 30, 2021 · 4 comments
Open

changing nverts in graticule has no effect #16

dramanica opened this issue Apr 30, 2021 · 4 comments

Comments

@dramanica
Copy link

dramanica commented Apr 30, 2021

Changing the value of nverts has no effect on the number of vertices produced. From a quick look at the code, this parameter is not used at all in the graticule function.

@mdsumner
Copy link
Member

mdsumner commented May 4, 2021

thank you, was dimly aware this wasn't working - I've revisited the logic in another project and sadly haven't gotten back to this

are you interested in the tiles = TRUE form, that gives polygons, or just the lines?

@dramanica
Copy link
Author

Thanks for looking into this. The lines are all that I am interested in, so I am using tiles=FALSE

@mdsumner
Copy link
Member

mdsumner commented May 4, 2021

ok thanks, that's definitely a long-overdue fix - I was doing something with a minimum distance and I think I got side tracked ...

I'll commit an update, if you can test it from installing from github I'd appreciate that. Thanks!

It's still not ideal, but it'll be a while until I can port in some better code for this. And, having choice from internal logic and just override the 'nverts' is very much in the spirit of this package.

mdsumner added a commit that referenced this issue May 4, 2021
@dramanica
Copy link
Author

Thank you, it works just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants