Forthcoming GEOM 3.9.0 with Overlay-NG engine breaks sfdct

[rsbivand]

Unfortunately:

Running the tests in ‘tests/testthat.R’ failed.
Complete output:
  > library(testthat)
  > library(sfdct)
  > 
  > test_check("sfdct")
  ── 1. Failure: Square with wrong orientation (@test-prepair-benchmarks.R#41)  ──
  sf::st_as_text(st_geometry(fix_wkt(wkt))) == wkt isn't false.
  
  ══ testthat results  ═══════════════════════════════════════════════════════════
  [ OK: 45 | SKIPPED: 0 | WARNINGS: 3 | FAILED: 1 ]
  1. Failure: Square with wrong orientation (@test-prepair-benchmarks.R#41) 
  
  Error: testthat unit tests failed

Now:

> wo_wkt <- "POLYGON ((0 0, 0 10, 10 10, 10 0, 0 0))"
> wkt <- wo_wkt
> sf::st_as_text( st_geometry(fix_wkt(wkt)))
[1] "POLYGON ((0 0, 0 10, 10 10, 10 0, 0 0))"

and fix_wkt() is exposed to st_union() output using Overlay-NG.

[mdsumner]

Well, that's good! Thanks

[mdsumner]

Would you mind trying these examples in 3.9.0?

https://gist.github.com/mdsumner/e19eb4d059f464e06fe23c5ff3eda3f3

They are off topic here, but

[rsbivand]

I'll try later. Please also see https://lists.osgeo.org/pipermail/geos-devel/2020-October/009756.html and subsequent threads.

[rsbivand]

Example 1:

Error in CPL_nary_intersection(x) : 
  Evaluation error: TopologyException: found non-noded intersection between LINESTRING (28479.3 32612.9, 28410 32641.6) and LINESTRING (28460.1 32620.9, 28477 32613.9) at 28470.377703975006 32616.615566286771.

> st_precision(sample_buffs) <- 1e8
> st_intersection(sample_buffs)
Error in CPL_nary_intersection(x) : 
  Evaluation error: TopologyException: found non-noded intersection between LINESTRING (28111.3 32738.7, 28057.1 32751.7) and LINESTRING (28057.1 32751.7, 28057.1 32751.7) at 28057.124924306616 32751.686972727341.

Example 2:

Error in CPL_nary_intersection(x) : 
  Evaluation error: TopologyException: found non-noded intersection between LINESTRING (0.798068 0.573063, 0.82994 0.582411) and LINESTRING (0.811717 0.560594, 0.821814 0.580027) at 0.82181408436199366 0.58002734151053081.

> st_precision(sfx) <- 1e8
> sf::st_intersection(sfx)
Geometry set for 1162 features 
geometry type:  GEOMETRY
dimension:      XY
bbox:           xmin: -0.00637011 ymin: -0.01288492 xmax: 1.008897 ymax: 1.000598
CRS:            NA
First 5 geometries:
GEOMETRYCOLLECTION (LINESTRING (0.5024721 0.341...
GEOMETRYCOLLECTION (POLYGON ((0.9235043 0.77665...
POLYGON ((0.5517006 0.3114554, 0.5683856 0.2475...
MULTIPOLYGON (((0.4997257 0.3521596, 0.5037357 ...
GEOMETRYCOLLECTION (LINESTRING (0.6727729 0.498...

[mdsumner]

Great, thanks good to know!