crs structure is going to change

[edzer]

You're using constructs like

> silicate:::get_projection.sfc
function (x, ...) 
{
    attr(x, "crs")[["proj4string"]]
}

but upcoming sf will change the structure of crs objects; see e.g. r-spatial/sf#1225 . I will allow for a $ method that extracts a proj4string from a WKT represenation, so please change this into

    attr(x, "crs")$proj4string

if you want to stay in the proj4string realm.

[mdsumner]

Thanks for the heads up, you're saying we need the sf $ overload to get basic metadata? Don't bother we don't use sf

[edzer]

Others do, and get breaking packages because of silicate. You're on CRAN.

[mdsumner]

Thanks! And sorry for grumbling ...

[edzer]

still the case on CRAN; package eixport breaks for this reason; FYI @ibarraespinosa

[mdsumner]

Nearly ready, new silicate should hit CRAN within a day or so.

[ibarraespinosa]

Thanks. Now I will update eixport.

…

On Thu, Apr 9, 2020, 19:21 Michael Sumner ***@***.***> wrote: Closed #104 <#104>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#104 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGRM74B6TORJN2HB2LJGCGDRLZC5BANCNFSM4KPYFK5A> .