feat: metrics enabled config #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanericson
reviewed
Jan 26, 2023
| @@ -24,7 +24,7 @@ Before submitting a PR, make sure you run the linter & generate the go modules: | |||
| protolint config.proto | |||
| ``` | |||
| ```bash | |||
| make generate-proto | |||
| make generate-proto generate-env-vars | |||
There was a problem hiding this comment.
why this is suddenly needed? I thought it always generates the corresponding env var for the config field
There was a problem hiding this comment.
make generate-proto does that but does not update ENV.md with the new env vars.
ryanericson
approved these changes
Jan 26, 2023
prodion23
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Config to enable metrics. otel metrics will be used.