Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding length method to attribute list and updating http.url attribute in net/http instrumentation #224

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

varkey98
Copy link
Contributor

@varkey98 varkey98 commented Nov 23, 2023

Description

  1. adding a length method to attribute list
  2. Updating the http.url attribute in net/http instrumentation in case if its not the complete url

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08b9173) 58.77% compared to head (074687b) 58.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   58.77%   58.32%   -0.45%     
==========================================
  Files          55       55              
  Lines        2205     2210       +5     
==========================================
- Hits         1296     1289       -7     
- Misses        850      861      +11     
- Partials       59       60       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -65,7 +66,11 @@ func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
}

url := r.URL.String()
span.SetAttribute("http.url", url)
if strings.Contains(url, "://") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tim-mwangi tim-mwangi merged commit 3c97aac into hypertrace:main Nov 23, 2023
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants