build link b/w parent-child #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
============================================
+ Coverage 80.26% 80.29% +0.03%
Complexity 1166 1166
============================================
Files 102 102
Lines 4535 4542 +7
Branches 421 423 +2
============================================
+ Hits 3640 3647 +7
Misses 696 696
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
kotharironak
reviewed
Oct 6, 2021
...view-generator/src/main/java/org/hypertrace/viewgenerator/generators/ViewGeneratorState.java
Outdated
Show resolved
Hide resolved
...view-generator/src/main/java/org/hypertrace/viewgenerator/generators/ViewGeneratorState.java
Outdated
Show resolved
Hide resolved
…ester into follow_from_construct
|
@surajpuvvada added 1 test for traceState with FollowFrom link |
|
@kotharironak is PR good to merge now ? |
kotharironak
reviewed
Oct 8, 2021
...view-generator/src/main/java/org/hypertrace/viewgenerator/generators/ViewGeneratorState.java
Show resolved
Hide resolved
kotharironak
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for the follow_from construct for building parent-child relationship.
Ref: hypertrace/hypertrace#250
Data-model changes PR hypertrace/data-model#26