enable split commit by default (#127)

* enable split commit by default * added deepStoreUploadRetryEnabled config
hypertrace · Jul 13, 2023 · 808c8e1 · 808c8e1
1 parent 607017a
commit 808c8e1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/helm/templates/controller/configmap.yaml b/helm/templates/controller/configmap.yaml
@@ -26,10 +26,6 @@ data:
     controller.deleted.segments.retentionInDays={{ int .Values.controller.deleted.segments.retentionInDays }}
     controller.offline.segment.interval.checker.frequencyPeriod = {{ .Values.controller.offline.segment.interval.checker.frequencyPeriod }}
     {{- if eq .Values.cluster.storage.scheme "gs" }}
-    {{- if .Values.cluster.splitCommitEnabled }}
-    controller.allow.hlc.tables=false
-    controller.enable.split.commit=true
-    {{- end }}
     controller.local.temp.dir={{ .Values.controller.local.temp.dir }}
     pinot.controller.storage.factory.class.gs=org.apache.pinot.plugin.filesystem.GcsPinotFS
     pinot.controller.storage.factory.gs.projectId={{ .Values.cluster.storage.gs.projectId }}
@@ -45,4 +41,9 @@ data:
     pinot.controller.segment.fetcher.s3.class=org.apache.pinot.common.utils.fetcher.PinotFSSegmentFetcher
     pinot.controller.storage.factory.s3.disableAcl=false
     {{- end }}
+    {{- if .Values.cluster.splitCommitEnabled }}
+    controller.allow.hlc.tables=false
+    controller.enable.split.commit=true
+    controller.realtime.segment.deepStoreUploadRetryEnabled=true
+    {{- end }}
 {{- end }}
diff --git a/helm/templates/server/configmap.yaml b/helm/templates/server/configmap.yaml
@@ -40,10 +40,6 @@ data:
     {{- end }}
     {{- end }}
     {{- if eq $.Values.cluster.storage.scheme "gs" }}
-    {{- if $.Values.cluster.splitCommitEnabled }}
-    pinot.server.instance.enable.split.commit=true
-    pinot.server.instance.segment.store.uri={{ $.Values.controller.data.dir }}
-    {{- end }}
     pinot.server.storage.factory.class.gs=org.apache.pinot.plugin.filesystem.GcsPinotFS
     pinot.server.storage.factory.gs.projectId={{ $.Values.cluster.storage.gs.projectId }}
     pinot.server.storage.factory.gs.gcpKey={{ $.Values.cluster.storage.gs.gcpKey }}
@@ -57,5 +53,9 @@ data:
     pinot.server.segment.fetcher.s3.class=org.apache.pinot.common.utils.fetcher.PinotFSSegmentFetcher
     pinot.controller.storage.factory.s3.disableAcl=false
     {{- end }}
+    {{- if $.Values.cluster.splitCommitEnabled }}
+    pinot.server.instance.enable.split.commit=true
+    pinot.server.instance.segment.store.uri={{ $.Values.controller.data.dir }}
+    {{- end }}
 {{- end }}
 {{- end }}
diff --git a/helm/values.yaml b/helm/values.yaml
@@ -13,7 +13,7 @@ cluster:
   name: pinot
   storage:
     scheme: file
-  splitCommitEnabled: false
+  splitCommitEnabled: true
 
 controller:
   name: controller