Added support for handling simple attribute expression #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
============================================
- Coverage 82.48% 82.22% -0.26%
- Complexity 421 428 +7
============================================
Files 37 37
Lines 1604 1615 +11
Branches 169 175 +6
============================================
+ Hits 1323 1328 +5
- Misses 207 208 +1
- Partials 74 79 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
findingrish
approved these changes
Nov 25, 2021
findingrish
reviewed
Nov 25, 2021
| String logicalColumnName = expression.getColumnIdentifier().getColumnName(); | ||
| String col = viewDefinition.getKeyColumnNameForMap(logicalColumnName); | ||
| if ((expression.getValueCase() == COLUMNIDENTIFIER) | ||
| || (expression.getValueCase() == ATTRIBUTE_EXPRESSION && !isComplexAttribute(expression))) { |
There was a problem hiding this comment.
nit: (expression.getValueCase() == ATTRIBUTE_EXPRESSION && !isComplexAttribute(expression)) could be extracted into a method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref issue : #104