test: add projection with subpath test #132
Conversation
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
============================================
+ Coverage 81.39% 81.70% +0.30%
- Complexity 588 592 +4
============================================
Files 58 58
Lines 2268 2268
Branches 234 234
============================================
+ Hits 1846 1853 +7
+ Misses 327 319 -8
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| @@ -92,6 +93,30 @@ void transformsBasicAliasProjection() { | |||
| .blockingGet()); | |||
| } | |||
|
|
|||
| @Test | |||
| void transformsBasicAliasProjectionWithSubpath() { | |||
There was a problem hiding this comment.
Shouldn't this be in AttributeExpressionSubpathExistsFilteringTransformationTest and a corresponding CONTAINS_KEY filter be added ?
There was a problem hiding this comment.
No, this test isn't about CONTAINS_KEY filters, those tests already exist in the class you referenced. This test is verifying projection works when using a subpath.
|
@hypertrace/query-layer-owners please review. |
Description
Followup from #129 - new test for a projection of an attribute expression with subpath, and upgrading log4j for a minor vulnerability that doesn't affect this service.
Testing
Ran all tests locally.
Checklist: