handle array columns in Trino handler #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
============================================
+ Coverage 70.43% 72.71% +2.28%
- Complexity 1047 1091 +44
============================================
Files 96 96
Lines 4762 4780 +18
Branches 549 550 +1
============================================
+ Hits 3354 3476 +122
+ Misses 1188 1080 -108
- Partials 220 224 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kotharironak
approved these changes
Oct 25, 2023
| if (operator.equals("!=") || operator.equals("NOT IN")) { | ||
| // Support only equals and IN operator | ||
| if (operator.equals("=") || operator.equals("!=")) { | ||
| // Equals (=): CONTAINS(ip_types, 'Bot') |
There was a problem hiding this comment.
Nit: changes looks fine. For readability, would it make sense to move to a function?
| } else if (operator.equals("IN") || operator.equals("NOT IN")) { | ||
| // IN: CARDINALITY(ARRAY_INTERSECT(ip_types, ARRAY['Public Proxy', 'Bot'])) > 0 | ||
| // NOT IN: CARDINALITY(ARRAY_INTERSECT(ip_types, ARRAY['Public Proxy', 'Bot'])) = 0 | ||
| builder.append("CARDINALITY("); |
There was a problem hiding this comment.
Nit: changes looks fine. For readability, would it make sense to move to a function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.