Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IS_TRINO_ATTRIBUTE and compare with ignore case #206

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

satish-mittal
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #206 (79c9bbd) into main (5af04d3) will decrease coverage by 4.08%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #206      +/-   ##
============================================
- Coverage     70.43%   66.35%   -4.08%     
+ Complexity     1047     1037      -10     
============================================
  Files            96       93       -3     
  Lines          4762     4729      -33     
  Branches        549      549              
============================================
- Hits           3354     3138     -216     
- Misses         1188     1385     +197     
+ Partials        220      206      -14     
Flag Coverage Δ
integration ?
unit 66.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../query/service/trino/TrinoBasedRequestHandler.java 0.00% <0.00%> (ø)
...e/core/query/service/trino/TrinoFilterHandler.java 61.53% <0.00%> (ø)

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@satish-mittal satish-mittal merged commit 51f63c8 into main Oct 12, 2023
5 of 8 checks passed
@satish-mittal satish-mittal deleted the fix_span_attr branch October 12, 2023 14:11
@github-actions
Copy link

Unit Test Results

  40 files  ±0    40 suites  ±0   12s ⏱️ ±0s
289 tests ±0  289 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 51f63c8. ± Comparison against base commit 5af04d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants