Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dateTimeConvert function in Trino #212

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

satish-mittal
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #212 (759b775) into main (0204dde) will increase coverage by 0.25%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #212      +/-   ##
============================================
+ Coverage     72.71%   72.97%   +0.25%     
- Complexity     1091     1097       +6     
============================================
  Files            96       96              
  Lines          4780     4781       +1     
  Branches        550      550              
============================================
+ Hits           3476     3489      +13     
+ Misses         1080     1065      -15     
- Partials        224      227       +3     
Flag Coverage Δ
integration 72.97% <100.00%> (+0.25%) ⬆️
unit 68.93% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rvice/trino/converters/TrinoFunctionConverter.java 26.35% <100.00%> (+8.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions

This comment has been minimized.

@satish-mittal satish-mittal merged commit 2c4635c into main Oct 26, 2023
8 checks passed
@satish-mittal satish-mittal deleted the trino_datetimeconvert branch October 26, 2023 12:29
@github-actions
Copy link

Unit Test Results

  40 files  ±0    40 suites  ±0   14s ⏱️ +4s
307 tests +4  307 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 2c4635c. ± Comparison against base commit 0204dde.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants