Adding average rate logic in query service #87

sarthak77 · 2021-09-23T03:37:35Z

Following tasks have been performed as a part of this PR :

Add support for average rate function in query service (changes made in primarily in PinotFunctionConverter)
Extract time ranges from query request which is required in computing average rate (changes made in primarily in ExecutionContext)
Changed interface of RequestHandler to add support for parsing timeColumn name directly from config

codecov · 2021-09-23T05:41:09Z

Codecov Report

Merging #87 (21acc1f) into main (c56ccad) will increase coverage by 0.86%.
The diff coverage is 97.87%.

@@             Coverage Diff              @@
##               main      #87      +/-   ##
============================================
+ Coverage     81.60%   82.47%   +0.86%     
- Complexity      391      419      +28     
============================================
  Files            37       37              
  Lines          1522     1603      +81     
  Branches        164      168       +4     
============================================
+ Hits           1242     1322      +80     
  Misses          207      207              
- Partials         73       74       +1

Flag	Coverage Δ
integration	`82.47% <97.87%> (+0.86%)`	⬆️
unit	`80.22% <97.87%> (+1.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...service/pinot/QueryRequestToPinotSQLConverter.java	`87.96% <94.11%> (+0.30%)`	⬆️
...ypertrace/core/query/service/ExecutionContext.java	`94.24% <98.14%> (+2.47%)`	⬆️
...ypertrace/core/query/service/QueryServiceImpl.java	`100.00% <100.00%> (ø)`
.../query/service/pinot/PinotBasedRequestHandler.java	`71.17% <100.00%> (+0.10%)`	⬆️
...rvice/pinot/converters/PinotFunctionConverter.java	`94.80% <100.00%> (+1.58%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56ccad...21acc1f. Read the comment docs.

query-service-impl/build.gradle.kts

...src/main/java/org/hypertrace/core/query/service/pinot/converters/PinotFunctionConverter.java

...l/src/main/java/org/hypertrace/core/query/service/pinot/QueryRequestToPinotSQLConverter.java

...ice-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java

...src/integrationTest/java/org/hypertrace/core/query/service/htqueries/HTPinotQueriesTest.java

...ce/src/integrationTest/java/org/hypertrace/core/query/service/htqueries/ServicesQueries.java

...l/src/main/java/org/hypertrace/core/query/service/pinot/QueryRequestToPinotSQLConverter.java

...ice-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java

...l/src/main/java/org/hypertrace/core/query/service/pinot/QueryRequestToPinotSQLConverter.java

...ice-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java

...y-service-impl/src/test/java/org/hypertrace/core/query/service/QueryRequestBuilderUtils.java

aaron-steinfeld

everything left is small/nits I believe.

query-service-impl/src/main/java/org/hypertrace/core/query/service/ExecutionContext.java

...y-service-impl/src/test/java/org/hypertrace/core/query/service/QueryRequestBuilderUtils.java

...service-impl/src/test/java/org/hypertrace/core/query/service/pinot/ExecutionContextTest.java

...ce/src/integrationTest/java/org/hypertrace/core/query/service/htqueries/ServicesQueries.java

query-service-impl/src/main/java/org/hypertrace/core/query/service/ExecutionContext.java

...y-service-impl/src/test/java/org/hypertrace/core/query/service/QueryRequestBuilderUtils.java

...ervice/src/integrationTest/java/org/hypertrace/core/query/service/QueryServiceTestUtils.java

github-actions · 2021-10-15T05:07:10Z

Unit Test Results

  22 files ±  0   22 suites ±0 7s ⏱️ -4s
124 tests +11 124 ✔️ +11 0 💤 ±0 0 ❌ ±0

Results for commit aa88793. ± Comparison against base commit c56ccad.

init commit

9ca540d

sarthak77 requested review from a team, kotharironak and findingrish September 23, 2021 03:37

Sarthak Singhal added 2 commits September 23, 2021 11:09

updated tests

8ce1e48

removed debug statement

a93b752

This comment has been minimized.

Sign in to view

sarthak77 marked this pull request as draft September 23, 2021 06:15

Sarthak Singhal added 3 commits September 23, 2021 12:20

modified test

ae7e640

added support for sum and avg_rate

aad7af7

updated test files

7f0097c

This comment has been minimized.

Sign in to view

sarthak77 marked this pull request as ready for review September 23, 2021 07:42

aaron-steinfeld requested changes Sep 23, 2021

View reviewed changes

Sarthak Singhal added 2 commits September 24, 2021 08:12

refactored

089cb3c

added test

4f2692f

This comment has been minimized.

Sign in to view

kotharironak reviewed Sep 24, 2021

View reviewed changes

refactored

334b090

This comment has been minimized.

Sign in to view

findingrish reviewed Sep 24, 2021

View reviewed changes

...l/src/main/java/org/hypertrace/core/query/service/pinot/QueryRequestToPinotSQLConverter.java Outdated Show resolved Hide resolved

changed map signature

f0c2675

This comment has been minimized.

Sign in to view

findingrish reviewed Sep 24, 2021

View reviewed changes

...ice-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java Outdated Show resolved Hide resolved

kotharironak reviewed Sep 24, 2021

View reviewed changes

...ice-impl/src/main/java/org/hypertrace/core/query/service/pinot/PinotBasedRequestHandler.java Outdated Show resolved Hide resolved

Sarthak Singhal added 2 commits September 24, 2021 12:30

refactored the code

d53b439

updated tests

216ace8

This comment has been minimized.

Sign in to view

kotharironak reviewed Oct 14, 2021

View reviewed changes

...y-service-impl/src/test/java/org/hypertrace/core/query/service/QueryRequestBuilderUtils.java Outdated Show resolved Hide resolved

...y-service-impl/src/test/java/org/hypertrace/core/query/service/QueryRequestBuilderUtils.java Outdated Show resolved Hide resolved

Sarthak Singhal added 2 commits October 14, 2021 15:27

refactoring

b9e8f1f

minor refactorings

f182691

This comment has been minimized.

Sign in to view

sarthak77 requested a review from kotharironak October 14, 2021 10:26

aaron-steinfeld previously approved these changes Oct 14, 2021

View reviewed changes

resolved PR comments

31c1633

sarthak77 dismissed aaron-steinfeld’s stale review via 31c1633 October 14, 2021 15:35

This comment has been minimized.

Sign in to view

resolved PR comments

7052c4a

This comment has been minimized.

Sign in to view

aaron-steinfeld previously approved these changes Oct 14, 2021

View reviewed changes

query-service-impl/src/main/java/org/hypertrace/core/query/service/ExecutionContext.java Outdated Show resolved Hide resolved

nit changes

8d6152d

sarthak77 dismissed aaron-steinfeld’s stale review via 8d6152d October 14, 2021 17:10

This comment has been minimized.

Sign in to view

aaron-steinfeld reviewed Oct 14, 2021

View reviewed changes

...y-service-impl/src/test/java/org/hypertrace/core/query/service/QueryRequestBuilderUtils.java Outdated Show resolved Hide resolved

refactored integration tests

9c3606e

This comment has been minimized.

Sign in to view

resolved comments

12f8c3e

sarthak77 requested a review from aaron-steinfeld October 14, 2021 18:10

This comment has been minimized.

Sign in to view

aaron-steinfeld previously approved these changes Oct 14, 2021

View reviewed changes

resolved PR comments

21acc1f

sarthak77 dismissed aaron-steinfeld’s stale review via 21acc1f October 14, 2021 18:21

sarthak77 requested a review from aaron-steinfeld October 14, 2021 18:21

This comment has been minimized.

Sign in to view

aaron-steinfeld approved these changes Oct 14, 2021

View reviewed changes

sarthak77 merged commit aa88793 into main Oct 15, 2021

sarthak77 deleted the cleaning_avg_rate branch October 15, 2021 05:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding average rate logic in query service #87

Adding average rate logic in query service #87

sarthak77 commented Sep 23, 2021 •

edited

Loading

codecov bot commented Sep 23, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aaron-steinfeld left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 15, 2021

Adding average rate logic in query service #87

Adding average rate logic in query service #87

Conversation

sarthak77 commented Sep 23, 2021 • edited Loading

codecov bot commented Sep 23, 2021 • edited Loading

Codecov Report

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aaron-steinfeld left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 15, 2021

Unit Test Results

sarthak77 commented Sep 23, 2021 •

edited

Loading

codecov bot commented Sep 23, 2021 •

edited

Loading