Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QS for AVGRATE bug #91

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Update QS for AVGRATE bug #91

merged 2 commits into from
Oct 27, 2021

Conversation

sarthak77
Copy link
Member

@sarthak77 sarthak77 commented Oct 27, 2021

Changed signature of average rate function from AVG_RATE to AVGRATE. Gateway service uses AVGRATE and query service was using AVG_RATE which caused an error.

@sarthak77 sarthak77 requested review from a team and kotharironak October 27, 2021 08:24
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #91 (6c02576) into main (c62e04f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #91   +/-   ##
=========================================
  Coverage     82.47%   82.47%           
  Complexity      419      419           
=========================================
  Files            37       37           
  Lines          1603     1603           
  Branches        168      168           
=========================================
  Hits           1322     1322           
  Misses          207      207           
  Partials         74       74           
Flag Coverage Δ
integration 82.47% <ø> (ø)
unit 80.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvice/pinot/converters/PinotFunctionConverter.java 94.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62e04f...6c02576. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link

@findingrish findingrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was _ posing any problems?

@sarthak77 sarthak77 merged commit eb93841 into main Oct 27, 2021
@sarthak77 sarthak77 deleted the bug-fix branch October 27, 2021 08:33
@sarthak77
Copy link
Member Author

Was _ posing any problems?

Yes
In gateway we use AVGRATE so both were not matching which caused an error.

@findingrish
Copy link

Was _ posing any problems?

Yes In gateway we use AVGRATE so both were not matching which caused an error.

It's generally a good idea to provide this context in the description.

@github-actions
Copy link

Unit Test Results

  22 files  ±0    22 suites  ±0   9s ⏱️ +2s
124 tests ±0  124 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit eb93841. ± Comparison against base commit c62e04f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants