Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated proto files #98

Merged
merged 9 commits into from
Nov 17, 2021
Merged

Updated proto files #98

merged 9 commits into from
Nov 17, 2021

Conversation

sarthak77
Copy link
Member

As a part of this PR, updated the proto message to add attribute expression. Also updated files to incorporate snyk changes.

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #98 (bf60a78) into main (5ea65bf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #98   +/-   ##
=========================================
  Coverage     82.47%   82.47%           
  Complexity      419      419           
=========================================
  Files            37       37           
  Lines          1603     1603           
  Branches        168      168           
=========================================
  Hits           1322     1322           
  Misses          207      207           
  Partials         74       74           
Flag Coverage Δ
integration 82.47% <ø> (ø)
unit 80.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea65bf...bf60a78. Read the comment docs.

Copy link
Contributor

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions

This comment has been minimized.

@sarthak77 sarthak77 merged commit 225ab2e into main Nov 17, 2021
@sarthak77 sarthak77 deleted the proto_update branch November 17, 2021 07:49
@github-actions
Copy link

Unit Test Results

  22 files  ±0    22 suites  ±0   7s ⏱️ -1s
124 tests ±0  124 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 225ab2e. ± Comparison against base commit 5ea65bf.

@kotharironak
Copy link
Contributor

Tagging the ticket - hypertrace/hypertrace-ui#1099

@kotharironak
Copy link
Contributor

For ticket - hypertrace/hypertrace-ui#1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants