Feature/dtpayetwo 759 hw parity paypal account java dev #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akswaminathan-pp-dev
requested review from
dhsoundararajan-pp-dev and
grmeyer-hw-dev
dhsoundararajan-pp-dev
approved these changes
Dec 2, 2022
… feature/DTPAYETWO-759-HWParity_PaypalAccountJavaDev # Conflicts: # CHANGELOG.md # src/test/java/com/hyperwallet/clientsdk/HyperwalletIT.java
| @@ -3377,6 +3377,93 @@ public void testGetPayPalAccountDefaultTransfer() throws Exception { | |||
| String functionality = "getPayPalAccountDefaultTransfer"; | |||
| initMockServer(functionality); | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
The testGetPayPalAccountDefaultTransfer() method is missing code.
| @@ -3377,6 +3377,93 @@ public void testGetPayPalAccountDefaultTransfer() throws Exception { | |||
| String functionality = "getPayPalAccountDefaultTransfer"; | |||
| initMockServer(functionality); | |||
|
|
|||
| @Test | |||
| public void createPayPalAccountWithAccountId() throws Exception { | |||
There was a problem hiding this comment.
Minor The test name should be testCreatePayPalAccountWithAccountId()
delete-merged-branch
bot
deleted the
feature/DTPAYETWO-759-HWParity_PaypalAccountJavaDev
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: DTPAYETWO-759
JIRA Tickets:
Overview
The Design Documentation can be found here: HW Parity with Masspay (REST API)
Currently when creating External Accounts (EA) such as PayPal & Venmo through the REST API method, account numbers were specified to be the following:
This has now been changed to support the following:
With this change, there is a new option to use the "accountId" key-value pair in the HTTP POST Request Body. When GETting an EA, the response body will show this "accountId" value as well. Users are still able to use the "email" key-value if they wish to as well.
Added new wallet attribute USE_EMAIL_TAG_FOR_PAYPAL_EA_REST_API.
Hence we have added a generic error 'email/accountId is required' to accomodate both based on wallet attribute USE_EMAIL_TAG_FOR_PAYPAL_EA_REST_API. Moving forward all merchants will start using accountId.