Feature/hw 58111 java remove filters #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| response = getService(url, true).getResource(); | ||
| Request req = getService(url, true); | ||
| response = req.getResource(); | ||
| //response = getService(url, true).getResource(); |
There was a problem hiding this comment.
Revert the changes in this file.
There was a problem hiding this comment.
Reverted the changes
| String url = paginate(this.url + "/users", options); | ||
| if (options != null) { | ||
| if (options.getClientUserId() != null) { |
There was a problem hiding this comment.
The addParameter function already checks for null values. So just check whether the options is null or not and then call the addParameter without null checks.
This is a generic comment. Please change in all the places.
There was a problem hiding this comment.
Done for the whole file
There was a problem hiding this comment.
Made changes for the whole file.
| /* | ||
| Following test is not returning response. This is dissabled timebeing. To be rerun after enabling. | ||
| */ | ||
| @Test(enabled = false) |
There was a problem hiding this comment.
Please enable all the tests.
There was a problem hiding this comment.
enabled and tested the test case.
…erwallet/java-sdk into feature/HW-58111-java-remove-filters
ramahalingam
approved these changes
Sep 14, 2020
vkorotchenko
approved these changes
Sep 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.