Also run tests with JDK 8 when compiling with JDK 11 and 17

Except on RISC-V where JDK 8 is not supported. But given there is no RISC-V specific code, it would be verified that compiling with JDK 11/17 and running on JDK 8 still functions.
hyperxpro · Oct 25, 2023 · ace44cb · ace44cb
1 parent 837b65e
commit ace44cb
Show file tree

Hide file tree

Showing 5 changed files with 89 additions and 23 deletions.
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
@@ -26,7 +26,7 @@ jobs:
           java-version: 8
           architecture: x64
       - name: Build with Maven
-        run: mvn -B -ntp clean package --file pom.xml
+        run: mvn -B --show-version -ntp clean package --file pom.xml
       - name: Upload the build
         uses: actions/upload-artifact@v3
         with:
@@ -44,7 +44,15 @@ jobs:
           java-version: 11
           architecture: x64
       - name: Build with Maven
-        run: mvn -B -ntp clean package --file pom.xml
+        run: mvn -B --show-version -ntp --file pom.xml clean package
+      - name: Set up JDK 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'corretto'
+          java-version: 8
+          architecture: x64
+      - name: Test with JDK 8
+        run: mvn -B --show-version -ntp --file pom.xml surefire:test
 
   MacOS-x86_64-Build-JDK17:
     runs-on: macos-latest
@@ -57,7 +65,15 @@ jobs:
           java-version: 17
           architecture: x64
       - name: Build with Maven
-        run: mvn -B -ntp clean package --file pom.xml
+        run: mvn -B --show-version -ntp --file pom.xml clean package
+      - name: Set up JDK 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'corretto'
+          java-version: 8
+          architecture: x64
+      - name: Test with JDK 8
+        run: mvn -B --show-version -ntp --file pom.xml surefire:test
 
   Linux-x86_64-Build-JDK8:
     runs-on: ubuntu-latest
@@ -125,7 +141,7 @@ jobs:
           run: |
             export JAVA_HOME="/jdk"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            ./mvnw -B --show-version -ntp clean package
 
       - name: Upload the build
         uses: actions/upload-artifact@v3
@@ -167,12 +183,14 @@ jobs:
             apt-get install -q -y curl gnupg2 autoconf automake libtool make tar git cmake build-essential
 
             curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . ~/.jabba/jabba.sh
+            jabba install 1.8.0-custom=tgz+https://corretto.aws/downloads/resources/8.352.08.1/amazon-corretto-8.352.08.1-linux-aarch64.tar.gz -o /jdk8
             jabba install 11.0.0-custom=tgz+https://corretto.aws/downloads/resources/11.0.17.8.1/amazon-corretto-11.0.17.8.1-linux-aarch64.tar.gz -o /jdk
           
           run: |
-            export JAVA_HOME="/jdk"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            JAVA_HOME=/jdk ./mvnw -B --show-version -ntp clean package
+            # Test with JDK 8
+            JAVA_HOME=/jdk8 ./mvnw -B --show-version -ntp surefire:test
 
   Linux-Aarch64-Build-JDK17:
     runs-on: ubuntu-latest
@@ -208,13 +226,15 @@ jobs:
             apt-get install -q -y curl gnupg2 autoconf automake libtool make tar git cmake build-essential
 
             curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . ~/.jabba/jabba.sh
+            jabba install 1.8.0-custom=tgz+https://corretto.aws/downloads/resources/8.352.08.1/amazon-corretto-8.352.08.1-linux-aarch64.tar.gz -o /jdk8
             jabba install 17.0.0-custom=tgz+https://corretto.aws/downloads/resources/17.0.5.8.1/amazon-corretto-17.0.5.8.1-linux-aarch64.tar.gz -o /jdk
           
           run: |
             export MAVEN_OPTS="-Djdk.lang.Process.launchMechanism=vfork"
-            export JAVA_HOME="/jdk"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            JAVA_HOME=/jdk ./mvnw -B --show-version -ntp clean package
+            # Test with JDK 8
+            JAVA_HOME=/jdk8 ./mvnw -B --show-version -ntp surefire:test
 
   Linux-ArmV7-Build-JDK8:
     runs-on: ubuntu-latest
@@ -255,7 +275,7 @@ jobs:
           run: |
             export JAVA_HOME="/jdk"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            ./mvnw -B --show-version -ntp clean package
 
       - name: Upload the build
         uses: actions/upload-artifact@v3
@@ -297,12 +317,14 @@ jobs:
             apt-get install -q -y curl gnupg2 autoconf automake libtool make tar git cmake build-essential
 
             curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | bash && . ~/.jabba/jabba.sh
+            jabba install 1.8.0-custom=tgz+https://cdn.azul.com/zulu-embedded/bin/zulu8.66.0.15-ca-jdk8.0.352-linux_aarch32hf.tar.gz -o /jdk8
             jabba install 11.0.0-custom=tgz+https://cdn.azul.com/zulu-embedded/bin/zulu11.60.19-ca-jdk11.0.17-linux_aarch32hf.tar.gz -o /jdk
           
           run: |
-            export JAVA_HOME="/jdk"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            JAVA_HOME=/jdk ./mvnw -B --show-version -ntp clean package
+            # Test with JDK 8
+            JAVA_HOME=/jdk8 ./mvnw -B --show-version -ntp surefire:test
             
   Linux-s390x-Build-JDK8:
     runs-on: ubuntu-latest
@@ -339,7 +361,7 @@ jobs:
           
           run: |
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            ./mvnw -B --show-version -ntp clean package
 
       - name: Upload the build
         uses: actions/upload-artifact@v3
@@ -378,11 +400,13 @@ jobs:
           # Install dependencies
           install: |
             apt-get update
-            apt-get install -q -y curl gnupg2 autoconf automake libtool make tar git cmake build-essential openjdk-11-jdk
+            apt-get install -q -y curl gnupg2 autoconf automake libtool make tar git cmake build-essential openjdk-8-jdk openjdk-11-jdk
 
           run: |
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            JAVA_HOME=/usr/lib/jvm/java-11-openjdk-$(uname -m) ./mvnw -B --show-version -ntp clean package
+            # Test with JDK 8
+            JAVA_HOME=/usr/lib/jvm/java-8-openjdk-$(uname -m) ./mvnw -B --show-version -ntp surefire:test
 
   Linux-riscv64-Build-JDK11:
     runs-on: ubuntu-latest
@@ -419,7 +443,7 @@ jobs:
           run: |
             export MAVEN_OPTS="-Djdk.lang.Process.launchMechanism=vfork"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            ./mvnw -B --show-version -ntp clean package
 
   Linux-riscv64-Build-JDK17:
     runs-on: ubuntu-latest
@@ -456,7 +480,7 @@ jobs:
           run: |
             export MAVEN_OPTS="-Djdk.lang.Process.launchMechanism=vfork"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            ./mvnw -B --show-version -ntp clean package
 
   Linux-riscv64-Build-JDK21:
     runs-on: ubuntu-latest
@@ -497,7 +521,7 @@ jobs:
           run: |
             export JAVA_HOME="/jdk"
             chmod +x ./mvnw
-            ./mvnw -B -ntp clean package
+            ./mvnw -B --show-version -ntp clean package
 
   Windows-x86_64-Build-JDK8:
     runs-on: windows-latest
@@ -512,7 +536,7 @@ jobs:
       - name: Enable Developer Command Prompt
         uses: ilammy/msvc-dev-cmd@v1.12.0
       - name: Build with Maven
-        run: mvn -B -ntp clean package --file pom.xml
+        run: mvn -B --show-version -ntp clean package --file pom.xml
       - name: Upload the build
         uses: actions/upload-artifact@v3
         with:
@@ -533,7 +557,15 @@ jobs:
       - name: Enable Developer Command Prompt
         uses: ilammy/msvc-dev-cmd@v1.12.0
       - name: Build with Maven
-        run: mvn -B -ntp clean package --file pom.xml
+        run: mvn -B --show-version -ntp --file pom.xml clean package
+      - name: Set up JDK 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'corretto'
+          java-version: 8
+          architecture: x64
+      - name: Test with JDK 8
+        run: mvn -B --show-version -ntp --file pom.xml surefire:test
 
   Windows-x86_64-Build-JDK17:
     runs-on: windows-latest
@@ -548,4 +580,12 @@ jobs:
       - name: Enable Developer Command Prompt
         uses: ilammy/msvc-dev-cmd@v1.12.0
       - name: Build with Maven
-        run: mvn -B -ntp clean package --file pom.xml
+        run: mvn -B --show-version -ntp --file pom.xml clean package
+      - name: Set up JDK 8
+        uses: actions/setup-java@v3
+        with:
+          distribution: 'corretto'
+          java-version: 8
+          architecture: x64
+      - name: Test with JDK 8
+        run: mvn -B --show-version -ntp --file pom.xml surefire:test
diff --git a/docker/Dockerfile11.centos6 b/docker/Dockerfile11.centos6
@@ -4,7 +4,14 @@ RUN rm -vf /usr/lib64/libstdc++.so.6.0.24-gdb.py
 
 RUN yum -y install \
             git 
-
+
+RUN export java8_version=amazon-corretto@1.8.292-10.1 && \
+    export JAVA8_VERSION=$java8_version && \
+    curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | JABBA_COMMAND="install $JAVA8_VERSION -o /jdk8" bash && \
+    echo 'export JAVA8_HOME="/jdk8"' >> ~/.bashrc
+
+ENV JAVA8_HOME "/jdk8"
+
 RUN export java_version=amazon-corretto@1.11.0-11.9.1 && \
     export JAVA_VERSION=$java_version && \
     curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | JABBA_COMMAND="install $JAVA_VERSION -o /jdk" bash && \

diff --git a/docker/Dockerfile17.centos6 b/docker/Dockerfile17.centos6
@@ -5,6 +5,13 @@ RUN rm -vf /usr/lib64/libstdc++.so.6.0.24-gdb.py
 RUN yum -y install \
             git 
 
+RUN export java8_version=amazon-corretto@1.8.292-10.1 && \
+    export JAVA8_VERSION=$java8_version && \
+    curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | JABBA_COMMAND="install $JAVA8_VERSION -o /jdk8" bash && \
+    echo 'export JAVA8_HOME="/jdk8"' >> ~/.bashrc
+
+ENV JAVA8_HOME "/jdk8"
+
 RUN export java_version=amazon-corretto@1.17.0-0.35.1 && \
     export JAVA_VERSION=$java_version && \
     curl -sL https://github.com/shyiko/jabba/raw/master/install.sh | JABBA_COMMAND="install $JAVA_VERSION -o /jdk" bash && \

diff --git a/docker/docker-compose11.yml b/docker/docker-compose11.yml
@@ -18,7 +18,13 @@ services:
 
   build:
     <<: *common
-    command: /bin/bash -cl "mvn -B -ntp clean package --file pom.xml"
+    command:
+      - /bin/bash
+      - -cl
+      - |
+        JAVA_HOME=/jdk  mvn -B --show-version -ntp --file pom.xml clean package
+        # Test with JDK 8
+        JAVA_HOME=/jdk8 mvn -B --show-version -ntp --file pom.xml surefire:test
 
   shell:
     <<: *common

diff --git a/docker/docker-compose17.yml b/docker/docker-compose17.yml
@@ -18,7 +18,13 @@ services:
 
   build:
     <<: *common
-    command: /bin/bash -cl "mvn -B -ntp clean package --file pom.xml"
+    command:
+      - /bin/bash
+      - -cl
+      - |
+        JAVA_HOME=/jdk  mvn -B --show-version -ntp --file pom.xml clean package
+        # Test with JDK 8
+        JAVA_HOME=/jdk8 mvn -B --show-version -ntp --file pom.xml surefire:test
 
   shell:
     <<: *common